Update Substrate with Keyboard fixes for predictive text and non-predictive keyboard#1353
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Android MainActivity IME integration to improve behavior when switching focus between JavaFX text controls and when using predictive vs non-predictive keyboards.
Changes:
- Forces
InputMethodManager.restartInput(...)when showing the IME (and when the active JavaFX node id changes) to reset IME internal state. - Tracks the active node id more defensively (volatile field, reset on hide) and binds an
InputConnectionto the node id at creation time. - Adds an Android
InputTypemapping for a “no suggestions” keyboard type.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #1350 and #1346
Progress