Skip to content

Update Substrate with Keyboard fixes for predictive text and non-predictive keyboard#1353

Merged
jperedadnr merged 2 commits into
gluonhq:masterfrom
jperedadnr:165-3-predictivetext
May 6, 2026
Merged

Update Substrate with Keyboard fixes for predictive text and non-predictive keyboard#1353
jperedadnr merged 2 commits into
gluonhq:masterfrom
jperedadnr:165-3-predictivetext

Conversation

@jperedadnr

Copy link
Copy Markdown
Contributor

Follow up of #1350 and #1346

Progress

Copilot AI review requested due to automatic review settings May 6, 2026 11:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Android MainActivity IME integration to improve behavior when switching focus between JavaFX text controls and when using predictive vs non-predictive keyboards.

Changes:

  • Forces InputMethodManager.restartInput(...) when showing the IME (and when the active JavaFX node id changes) to reset IME internal state.
  • Tracks the active node id more defensively (volatile field, reset on hide) and binds an InputConnection to the node id at creation time.
  • Adds an Android InputType mapping for a “no suggestions” keyboard type.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jperedadnr
jperedadnr merged commit 6f3f293 into gluonhq:master May 6, 2026
3 checks passed
@jperedadnr
jperedadnr deleted the 165-3-predictivetext branch May 6, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants