fix(release): drop private testing package from changeset#3
Merged
Conversation
The assembly-reload changeset listed both `@hotrepl/sdk` (published) and `@hotrepl/testing`. Under `privatePackages.version: false`, changesets treats `@hotrepl/testing` as ignored, and a single changeset may not mix ignored and non-ignored packages — so `changeset version` aborted with "Mixed changesets that contain both ignored and not ignored packages are not allowed", failing the Release workflow before it could open the Version PR. Private packages are neither versioned nor changelogged under this config, so the testing entry was inert noise. Drop it; the FakeRuntime helpers it covered are still described in the changeset body and ride the `@hotrepl/sdk` bump. `changeset status` now assembles cleanly: protocol 4.0.0, sdk 4.0.0, cli/mcp 3.0.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 4.0.0 Release workflow failed at
changeset version:Under
.changeset/config.jsonprivatePackages.version: false, the private@hotrepl/testingpackage is treated as ignored. Changesets forbids a singlechangeset that mixes ignored and non-ignored packages, so the
assembly-reload-cancelchangeset (which listed both@hotrepl/testingand@hotrepl/sdk) aborted versioning before the Version PR could be created.Private packages are neither versioned nor changelogged here, so the testing
entry was inert. Dropping it lets
changeset versionassemble cleanly:@hotrepl/protocol3.0.0 → 4.0.0@hotrepl/sdk3.0.0 → 4.0.0@hotrepl/cli/@hotrepl/mcp→ 3.0.1 (dependency-range patch)Verified locally with
bun changeset status.Follow-up (not in this PR): CI has no changeset-wellformedness gate, so this
only surfaced post-merge in the Release workflow. A
changeset statuscheck atPR time would catch it earlier, but needs
fetch-depth: 0and--sincehandling to behave under the shallow CI checkout — worth a dedicated change.