Finish remaining TODO items: bake hand CCs for adapted files + reconc… - #1893
Merged
Conversation
…ile resolved items Bake gate (behavioral fix): - PlaybackAssignmentCommands.applyAssignments no longer skips baking hand-position CCs (CC22/23/24) when creating an adapted file. The gate `blobMatchesAdapted = !createAdaptedFile` was left behind after its blocking bug (the adapted buffer never reaching disk) was fixed: the adapted bytes are now persisted via FileManager.replaceFileBytes / createDerivedFile before the bake step, so `targetFileId`'s blob is always correct and the editor CC pane is populated for adapted files too. - Add tests/apply-assignments-bake-adapted-hand-cc.test.js (3 cases). Stale-comment cleanup (commands verified already-implemented): - PlaybackControlCommands: playback_transpose is a real live global transpose (setGlobalTranspose), not a placeholder; set_tempo/set_volume are likewise implemented. Fix the file header and the transpose JSDoc. - SystemCommands: system_restore is fully implemented. Fix header. - MidiCommands: midi_reset is fully implemented. Fix header. Contract coverage: - Add executed playback_transpose contract tests (5 cases) and rewrite the orphan stub fixture to match the real live-offset behavior. TODO.md reconciliation (per audit Meta-constat #0 - stop re-triaging): - Mark ScoringConfig weight-sum and DelayCalibrator carte-regex resolved, with file:line evidence. - Record the octave-wrap collision decision: keep warning-only, because a nearest-free remap would break pitch-class preservation. - Note the adapted-file bake gate is lifted; correct stale dependency version numbers (better-sqlite3 is 11.x, not 9.x). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GPPovNdv6SbTBkx48QkVv1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ile resolved items
Bake gate (behavioral fix):
blobMatchesAdapted = !createAdaptedFilewas left behind after its blocking bug (the adapted buffer never reaching disk) was fixed: the adapted bytes are now persisted via FileManager.replaceFileBytes / createDerivedFile before the bake step, sotargetFileId's blob is always correct and the editor CC pane is populated for adapted files too.Stale-comment cleanup (commands verified already-implemented):
Contract coverage:
TODO.md reconciliation (per audit Meta-constat #0 - stop re-triaging):
Claude-Session: https://claude.ai/code/session_01GPPovNdv6SbTBkx48QkVv1