docs: resolve D-1 and fold in reviewer findings for agent/skill dashboard specs - #297
Merged
Merged
Conversation
…oard specs Both specs (issue #295 agent-stats-search, issue #296 skill-usage-report, milestone #8) had their D-1 decision confirmed by the user on 2026-09-02: agent-stats-search -> new top-level Agents tab (b); skill-usage-report -> new top-level Skills tab (a). Fold in project-reviewer's combined findings as required changes rather than open questions: - BLOCKING: the `_renderView` terminal `else` collision isn't closed by stacking a new branch ahead of it, since that `else` also dispatches the legitimate `advanced` tab. Both specs now require an explicit `advanced` branch and explicit no-match handling, landing first in agent-stats-search (issue #295), consumed by skill-usage-report (issue #296). - BLOCKING: cp-utils.js is an undeclared 6th (semantic, not textual) collision site -- agent-stats-search promotes CP.esc/CP.agentLeaf/ CP.AGENT_PATH_SEP; skill-usage-report's R-3 is now conditional on that landing first, avoiding re-copying esc() after promotion. - CONCERN (skill-usage-report): added a footnote distinguishing "invocations" (by_skill.invocation_count) from "times invoked" (by_skill_adoption. times_invoked) as different counting methods that can legitimately diverge, plus explicit "--" cells for the invoked-without-a-pass row. - NIT: recommend a follow-up issue promoting matchesNameFilter/ matchesAgentFilter to a single CP.matchesNameFilter; added a _VIEW_SUBS key-presence test-gate assertion to both specs' Phase 3. Recomputed open-decision counts (5->4 for #295, 7->6 for #296) and narrowed agent-stats-search's touches: frontmatter to drop the per-view-filter-box files that only apply under the D-1 option not chosen. Spec updates only, no code touched. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AoLZ2VNs8at1J1DML9NQoL
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finalizes the two scoping specs for milestone #8 (issues #295, #296):
docs/superpowers/specs/agent-stats-search.mddocs/superpowers/specs/skill-usage-report.mdBoth were produced by
project-planneras DRAFT with open decisions, then reviewed byproject-reviewer(findings: 2 BLOCKING, 1 CONCERN, 2 NIT). This PR:_renderViewsilent-fallthrough footgun and its fix, and the undeclaredcp-utils.js/CP-namespace collision between the two specs (with explicit sequencing: Dashboard: search/lookup any agent's stats, not just Top N #295 lands first, owns theCPpromotion; Dashboard: Skill Usage Report #296 depends on it)._VIEW_SUBStest-gate coverage).No code changes — spec files only. Neither issue is closed by this PR; both track the actual feature implementation, which hasn't started.
Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01AoLZ2VNs8at1J1DML9NQoL