fix: add AccountantOS dark variant#810
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesAccountantos icon metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR adds an AccountantOS dark-theme asset and updates its icon metadata. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| public/icons/accountantos/dark.svg | Adds a white dark-theme variant with unchanged logo geometry. |
| public/icons/accountantos/default.svg | Sets an explicit brand color and updates the accessible title. |
| src/data/icons.json | Registers the dark variant and updates AccountantOS aliases and categories. |
Reviews (1): Last reviewed commit: "fix: add AccountantOS dark variant" | Re-trigger Greptile
What changed
dark.svgvariant for AccountantOS while keeping the existing geometry unchanged.#09090Bbrand colour.Finance,Software, andPlatform.Accountant OSalias while retaining the descriptiveAccounting SoftwareandPractice Managementaliases.Why
The existing
currentColorSVG renders black when loaded as an external image in both site themes. Supplying an explicit dark variant keeps the logo visible on dark backgrounds and preserves the canonical AccountantOS name.Validation
git diff --checkpassed.The full package install was not bypassed when pnpm's minimum-release-age policy stopped two newly resolved transitive packages. The generated distribution validator also reports its existing Windows absolute-path import issue; the AccountantOS asset and data checks pass.
Summary by CodeRabbit