Skip to content

fix: add AccountantOS dark variant#810

Open
techbeezau wants to merge 1 commit into
glincker:mainfrom
techbeezau:agent/fix-accountantos-variants
Open

fix: add AccountantOS dark variant#810
techbeezau wants to merge 1 commit into
glincker:mainfrom
techbeezau:agent/fix-accountantos-variants

Conversation

@techbeezau

@techbeezau techbeezau commented Jul 20, 2026

Copy link
Copy Markdown

What changed

  • Added an explicit white dark.svg variant for AccountantOS while keeping the existing geometry unchanged.
  • Made the default/light asset explicitly use the official #09090B brand colour.
  • Categorized AccountantOS under Finance, Software, and Platform.
  • Removed the spaced Accountant OS alias while retaining the descriptive Accounting Software and Practice Management aliases.

Why

The existing currentColor SVG renders black when loaded as an external image in both site themes. Supplying an explicit dark variant keeps the logo visible on dark backgrounds and preserves the canonical AccountantOS name.

Validation

  • Both SVGs parse as valid XML.
  • Both SVGs are 5.2 KB, below the 50 KB limit.
  • Light and dark files use identical path geometry.
  • git diff --check passed.
  • Icon package build passed: 6,480 icons built.
  • Security audit passed: 12,964 files clean.
  • Lineage validation passed: 6,481 entries scanned.

The full package install was not bypassed when pnpm's minimum-release-age policy stopped two newly resolved transitive packages. The generated distribution validator also reports its existing Windows absolute-path import issue; the AccountantOS asset and data checks pass.

Summary by CodeRabbit

  • Enhancements
    • Expanded the Accountantos icon’s categorization to improve discoverability.
    • Added a dark variant for improved appearance across supported themes.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 88c2b1b2-7612-4168-b6c2-a8519918c38b

📥 Commits

Reviewing files that changed from the base of the PR and between 8731f4b and 5e55e7c.

⛔ Files ignored due to path filters (2)
  • public/icons/accountantos/dark.svg is excluded by !**/*.svg
  • public/icons/accountantos/default.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • src/data/icons.json

📝 Walkthrough

Walkthrough

The accountantos icon metadata now includes Software and Platform categories and a dark SVG variant path alongside the default variant.

Changes

Accountantos icon metadata

Layer / File(s) Summary
Update accountantos metadata
src/data/icons.json
Adds Software and Platform categories and the /icons/accountantos/dark.svg variant.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: icons

Suggested reviewers: thegdsks, phatjack

Poem

I’m a rabbit with a darker hue,
And extra categories hopping through.
Finance, Software, Platform in line,
My default and dark paths both now shine! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding the AccountantOS dark variant.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the icons Icon data, SVGs, or variants label Jul 20, 2026
@techbeezau
techbeezau marked this pull request as ready for review July 20, 2026 22:50
@greptile-apps

greptile-apps Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds an AccountantOS dark-theme asset and updates its icon metadata. The main changes are:

  • Adds a fixed white SVG for dark backgrounds.
  • Sets the default SVG to the official #09090B brand color.
  • Adds Software and Platform categories.
  • Removes the spaced alias and registers the dark variant.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
public/icons/accountantos/dark.svg Adds a white dark-theme variant with unchanged logo geometry.
public/icons/accountantos/default.svg Sets an explicit brand color and updates the accessible title.
src/data/icons.json Registers the dark variant and updates AccountantOS aliases and categories.

Reviews (1): Last reviewed commit: "fix: add AccountantOS dark variant" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons Icon data, SVGs, or variants

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants