fix(onboarding): wizard's first run never ran and never saved#287
Closed
gizmax wants to merge 1 commit into
Closed
fix(onboarding): wizard's first run never ran and never saved#287gizmax wants to merge 1 commit into
gizmax wants to merge 1 commit into
Conversation
Three defects in StepRun: - the API's input field is 'input'; the wizard sent 'inputs', which was silently dropped - the run started with no input data and failed required-field validation, so the user's first workflow 'did not start' - the template YAML ran inline and was never saved, so the first workflow also never appeared on the Workflows page; it is now saved via POST /workflows before running (best-effort - an existing name is fine) - /workflows/run returns 202 queued; the wizard pretended the queued run had already completed. It now polls the run to a terminal state (3s interval, 180s budget) and shows the real output or error.
Owner
Author
|
Superseded by #288 (contains this fix). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding #29 from first-run testing: 'inputs' vs 'input' (silently dropped -> required-field validation failure), inline run never saved the workflow, and the 202 queued response was presented as an instant success. Wizard now saves the workflow, runs with correct input, and polls to a terminal state. 23 wizard tests + full dashboard suite green.