fix(onboarding): tall wizard content was clipped and unscrollable#284
Closed
gizmax wants to merge 1 commit into
Closed
fix(onboarding): tall wizard content was clipped and unscrollable#284gizmax wants to merge 1 commit into
gizmax wants to merge 1 commit into
Conversation
min-h-screen + justify-center clips the top of content taller than the viewport (templates with many inputs, e.g. Employee Onboarding) and the clipped part is unreachable by scroll. Center via my-auto on the child instead - identical centering when short, natural page scroll when tall.
Owner
Author
|
Superseded by #285 (contains this fix). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
min-h-screen + justify-center clips content taller than the viewport and makes the top unreachable (Employee Onboarding template inputs). Centering moved to my-auto on the child - identical when short, page scrolls when tall. TS clean, 23 wizard tests pass.