Skip to content

fix(integrations): send a single notification when a token refresh fails #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giladresisi wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −5
Open

fix(integrations): send a single notification when a token refresh fails #1678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions libraries/nestjs-libraries/src/integrations/refresh.integration.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ export class RefreshIntegrationService {
.catch((err) => false);

if (!refresh || !refresh.accessToken) {
// informAboutRefreshError (with the failure cause) already notifies
// the user, and refreshNeeded sets the same flag disconnectChannel
// would — calling disconnectChannel here sent a second, cause-less
// copy of the same email for every failed refresh.
await this._integrationService.refreshNeeded(
integration.organizationId,
integration.id
Expand All @@ -89,11 +93,6 @@ export class RefreshIntegrationService {
cause
);

await this._integrationService.disconnectChannel(
integration.organizationId,
integration
);

return false;
}

Expand Down
Loading