Skip to content

fix(facebook): video/reel analytics via video_insights (no more nonexisting-field crash) #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giladresisi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(facebook): video/reel analytics via video_insights (no more nonexisting-field crash) #1669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 98 additions & 0 deletions libraries/nestjs-libraries/src/integrations/social/facebook.provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,6 +814,19 @@ export class FacebookProvider extends SocialAbstract implements SocialProvider {
): Promise<AnalyticsData[]> {
const today = dayjs().format('YYYY-MM-DD');

// The stored id (releaseId) shape depends on the post type set in post():
// - feed post -> `{pageid}_{postid}` (contains `_`), has an `insights` edge
// - reel/video -> bare numeric video id, NO `insights` edge (only `video_insights`)
// - story -> bare story id, no usable insights via this path
// There is no separate stored type, so id shape is the discriminator. Calling
// `/{videoId}/insights` on a video/story node returns
// `(#100) Tried accessing nonexisting field (insights)`, which is what surfaced
// in prod as "Error fetching Facebook post analytics: ApplicationFailure". Route
// bare ids to the video-only edge instead.
if (!postId.includes('_')) {
return this.videoPostAnalytics(accessToken, postId, today);
}

try {
// Fetch post insights from Facebook Graph API.
// post_impressions_unique was deprecated by Meta on 2026-06-15; it is replaced
Expand Down Expand Up @@ -884,4 +897,89 @@ export class FacebookProvider extends SocialAbstract implements SocialProvider {
return [];
}
}

// Video/reel posts store a bare video id whose node has no `insights` edge; their
// analytics live on the `/{videoId}/video_insights` edge instead. Story posts also
// store a bare id but have no usable insights here — the video_insights call comes
// back with an `error` (or empty data), which we swallow to an empty result so a
// single story/video can't break the statistics page.
private async videoPostAnalytics(
accessToken: string,
videoId: string,
today: string
): Promise<AnalyticsData[]> {
try {
// Metric names verified against the Graph API v23.0 video_insights docs:
// - total_video_impressions: times the video was shown
// - total_video_views: 3s+ (or full, if shorter) plays
// - total_video_reactions_by_type_total: reactions object, keyed by type
// Use plain fetch (not this.fetch) so a `(#100) nonexisting field` / story
// response doesn't throw an ApplicationFailure — we want a quiet `[]` instead.
const { data, error } = await (
await fetch(
`https://graph.facebook.com/v23.0/${videoId}/video_insights?metric=total_video_impressions,total_video_views,total_video_reactions_by_type_total&access_token=${accessToken}`
)
).json();

// Stories (and videos without this edge) come back with an error / no data —
// return an empty result quietly rather than logging a scary error. But a
// `nonexisting field (video_insights)` is the only "expected" error here; any
// other error (bad metric name, token, permissions) means the fix is silently
// returning empty when it shouldn't be, so surface it as a warning (not a throw,
// not a scary error) so it's diagnosable without breaking the statistics page.
if (error || !data || data.length === 0) {
if (error && !/nonexisting field/i.test(error.message || '')) {
console.warn('Facebook video_insights returned an error:', {
videoId,
error,
});
}
return [];
}

const result: AnalyticsData[] = [];

for (const metric of data) {
const value = metric.values?.[0]?.value;
if (value === undefined) continue;

let label = '';
let total = '';

switch (metric.name) {
case 'total_video_impressions':
label = 'Impressions';
total = String(value);
break;
case 'total_video_views':
label = 'Views';
total = String(value);
break;
case 'total_video_reactions_by_type_total':
// This returns an object with reaction types
if (typeof value === 'object') {
const totalReactions = Object.values(
value as Record<string, number>
).reduce((sum: number, v: number) => sum + v, 0);
label = 'Reactions';
total = String(totalReactions);
Comment on lines +961 to +965

@sentry sentry Bot Jul 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The check typeof value === 'object' does not exclude null, causing Object.values(null) to throw and discard all video analytics if the API returns null.
Severity: MEDIUM

Suggested Fix

Update the conditional check to explicitly exclude null before checking the type. The guard should be if (value !== null && typeof value === 'object').

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location:
libraries/nestjs-libraries/src/integrations/social/facebook.provider.ts#L961-L965

Potential issue: In the `videoPostAnalytics` function, when processing the
`total_video_reactions_by_type_total` metric, the code checks `typeof value ===
'object'`. In JavaScript, `typeof null` evaluates to `'object'`, so if the Facebook API
returns `null` for this metric, the condition passes. The code then attempts to execute
`Object.values(null)`, which throws a `TypeError`. This error is caught by a broader
`catch` block that returns an empty array, causing all analytics for the video post
(including impressions and views) to be discarded, not just the reaction data.

Did we get this right? 👍 / 👎 to inform future reviews.

}
break;
}

if (label) {
result.push({
label,
percentageChange: 0,
data: [{ total, date: today }],
});
}
}

return result;
} catch (err) {
console.error('Error fetching Facebook video post analytics:', err);
return [];
}
}
}
Loading