fix: token optimizer's self-exclusion bug#135
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the token optimizer’s self-exclusion logic so the optimizer/audit “AIC monitoring family” cannot end up as optimization targets when ranking workflows by AI credit spend.
Changes:
- Pre-filters
all-runs.jsonto remove runs belonging to the optimizer/audit workflows (byworkflow_pathandworkflow_name) before aggregating candidate rankings. - Updates the Phase 1 selection guardrail text to explicitly exclude the monitoring family by correct identifiers (rather than the non-matching
"Token"substring).
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/agentic-token-optimizer.md | Adds explicit pre-filtering of monitoring-family runs from the candidate pool and updates the selection guardrail text. |
| .github/workflows/agentic-token-optimizer.lock.yml | Regenerated lock workflow reflecting the updated log download + filtering logic. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Token Optimizer self-exclusion never matches: guard checks for "Token" in a name that is "AIC Usage Optimizer/Audit" #119
Fixes the token optimizer's self-exclusion bug. The optimizer currently tells itself to exclude workflows with "Token" in the name, but
gh aw logsreports the optimizer and audit workflows by display name:Agentic Workflow AIC Usage OptimizerDaily Agentic Workflow AIC Usage AuditNeither display name contains "Token", so the guard never matches. In practice that leaves the monitoring workflows in the ranking pool, and the optimizer can end up selecting itself or its sibling audit instead of a genuinely expensive target.