unified: Add inline expectation test library#22090
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces the Unified-language wrappers needed to use the shared inline-expectations test-postprocessing framework with Unified extractor locations and comments.
Changes:
- Adds a Unified-specific
InlineExpectationsTestImplimplementation mapping expectations to Unified comments/locations. - Adds a
@kind test-postprocessquery (InlineExpectationsTestQuery.ql) wiring the shared postprocessing with a UnifiedInputmodule. - Adds a small public-facing
InlineExpectationsTest.qllentry point exportingMake<Impl>for Unified tests.
Show a summary per file
| File | Description |
|---|---|
| unified/ql/lib/utils/test/internal/InlineExpectationsTestImpl.qll | Implements the Unified-specific InlineExpectationsTestSig adapter (comments + location type). |
| unified/ql/lib/utils/test/InlineExpectationsTestQuery.ql | Defines the Unified postprocess query entry point and relative-url formatting. |
| unified/ql/lib/utils/test/InlineExpectationsTest.qll | Provides a convenience import/export wrapper for Unified inline expectation tests. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Low
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
hvitved
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was going to add this alongside local scoping, but it's looking like it might be needed for other work first, so I thought we might as well get this in here.