Kotlin: Address inline expectations testFailures.#22079
Open
geoffw0 wants to merge 2 commits into
Open
Conversation
geoffw0
added
no-change-note-required
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Kotlin inline-expectations dataflow summary tests so that previously “unexpected” (spurious) results are explicitly annotated in-source, leaving the testFailures section in the corresponding .expected files empty again.
Changes:
- Added
// $ SPURIOUS: hasTaintFlow=...inline expectation tags for known spurious flows involvingPair,Triple,TimedValue, andMatchGroupaccessors/components. - Removed the now-resolved
testFailuresentries from the Kotlin1 and Kotlin2test.expectedfiles (section remains present but empty, consistent with other tests).
Show a summary per file
| File | Description |
|---|---|
| java/ql/test-kotlin2/library-tests/dataflow/summaries/test.kt | Adds SPURIOUS inline expectation tags for previously-unannotated spurious taint flows. |
| java/ql/test-kotlin2/library-tests/dataflow/summaries/test.expected | Removes resolved testFailures tuples so the section is empty again. |
| java/ql/test-kotlin1/library-tests/dataflow/summaries/test.kt | Mirrors the Kotlin2 SPURIOUS inline expectation annotations for Kotlin1 tests. |
| java/ql/test-kotlin1/library-tests/dataflow/summaries/test.expected | Removes resolved testFailures tuples so the section is empty again. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address testFailures in inline expectations tests. Annotations should always be updated so that the testFailures section of the .expected file is empty.
The issue here was missing inline expectations tags for spurious results involving pairs, triples etc. I don't know if we want to address this, but urgency is low.