Add include/exclude repo filters to team settings schema (backport #1009)

[decyjphr]

Summary

Backports PR #1009 onto the yadhav/fix-recent-issues line: adds include/exclude repo filters to the team settings schema, plus docs, a sample, and unit tests. No runtime changes — team entries are already filtered by the shared Diffable.filterEntries include/exclude logic (the same one collaborators use); the team schema simply never declared these keys, so editors and linters couldn't validate them.

Solves the same gap as upstream #1011 / #1009, for teams.

Why it's needed on this branch

• Collaborators already declare include/exclude in schema/settings.json; teams did not.
• The runtime already filters teams by include/exclude via Diffable.filterEntries, so configs using them work but fail schema validation in editors/linters.

What changed

• schema/settings.json — teams.items now mirrors the collaborators allOf pattern to declare include/exclude arrays.
• schema/dereferenced/settings.json — regenerated via npm run build:schema. (This also picked up pre-existing drift — app_installations — because the committed dereferenced file was stale relative to its source.)
• docs/github-settings/4. teams.md — documents include and exclude with examples.
• docs/sample-settings/settings.yml — adds sample teams using include/exclude.
• test/unit/lib/plugins/teams.test.js — 3 tests covering the filter path (adapted to this branch's github.teams.* mocks and toParams shape).
• smoke-test.js — new self-contained Phase 18 that exercises the feature end-to-end (--phase 18).

Adapted to this branch's layout

Unlike upstream, this branch consolidates schemas into a single schema/settings.json (no separate repos.json/suborgs.json), defines teams inline, and its team tests mock github.teams/github.repos (not github.rest.*) with toParams including team_id. The backport was reworked accordingly rather than cherry-picked.

Validation

• Unit tests: full suite 314 passed (3 new team filtering tests).
• Schema (AJV): the teams sub-schema now accepts valid include/exclude arrays and rejects bad types; confirmed the pre-backport schema did not declare them.
• Smoke test (live, org decyjphr-emu): node smoke-test.js --phase 18 → 7/7 passed — the include-matching team is applied; the exclude-matching and non-matching teams are correctly skipped.

Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com

[Copilot]

Pull request overview

This PR backports upstream work to declare include/exclude repo filters for teams entries in the settings schema, and documents/tests the behavior that already exists at runtime via Diffable.filterEntries.

Changes:

• Extend teams schema to allow include/exclude arrays (mirroring the collaborators allOf pattern) and regenerate the dereferenced schema.
• Add documentation and a sample config demonstrating team include/exclude filtering.
• Add unit tests and a new smoke-test phase to exercise include/exclude behavior end-to-end.

Show a summary per file

File	Description
schema/settings.json	Adds include/exclude properties under teams.items via allOf.
schema/dereferenced/settings.json	Regenerated dereferenced schema capturing the new teams shape plus previously uncommitted drift.
docs/github-settings/4. teams.md	Documents teams[].include / teams[].exclude semantics with examples.
docs/sample-settings/settings.yml	Adds sample team entries using include and exclude.
test/unit/lib/plugins/teams.test.js	Adds unit tests asserting filtering prevents/permits team application based on globs.
smoke-test.js	Adds Phase 18 smoke test to validate include/exclude behavior against a live org.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

schema/settings.json:157

• The include description is misleading/unclear and doesn't mention that values are glob patterns matched against the repo name. The docs describe this correctly, and Diffable.filterEntries() uses minimatch globs.

              "include": {
                "description": "You can include a list of repos for this team and only those repos would have this team",
                "type": "array",
                "items": {
                  "type": "string"

• Files reviewed: 6/6 changed files
• Comments generated: 2
• Review effort level: Low