Add deterministic cooldown decisions - #11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a deterministic cooldown evaluation API so callers can reproduce decisions at a supplied evaluation time and understand why a version is allowed/blocked (including selected cooldown, availability timestamp, and a typed reason), while keeping IsAllowed as a current-time wrapper for backwards compatibility.
Changes:
- Introduces
Decision/Reasontypes and a newConfig.Evaluate(..., evaluatedAt)method returning structured cooldown decisions. - Refactors
Config.IsAllowedto delegate toEvaluateusingtime.Now(). - Updates README usage/docs and adds unit tests covering the new decision behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Documents Config.Evaluate and adds an example showing decision/availability output. |
| cooldown.go | Adds Reason/Decision and implements deterministic evaluation via Config.Evaluate. |
| cooldown_test.go | Adds TestConfigEvaluate to validate decision outputs for disabled/elapsed/waiting/unknown cases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
113
to
117
| if cooldown == 0 { | ||
| decision.Allowed = true | ||
| decision.Reason = ReasonDisabled | ||
| return decision | ||
| } |
Comment on lines
+127
to
+145
| { | ||
| name: "disabled", | ||
| packagePURL: "pkg:npm/lodash", | ||
| publishedAt: evaluatedAt.Add(-time.Minute), | ||
| want: Decision{ | ||
| Allowed: true, | ||
| AvailableAt: evaluatedAt.Add(-time.Minute), | ||
| Reason: ReasonDisabled, | ||
| }, | ||
| }, | ||
| { | ||
| name: "unknown publication time", | ||
| packagePURL: "pkg:npm/express", | ||
| want: Decision{ | ||
| Allowed: true, | ||
| Cooldown: 3 * 24 * time.Hour, | ||
| Reason: ReasonUnknownPublicationTime, | ||
| }, | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds deterministic cooldown evaluation with the selected duration, availability time, and typed reason. Keeps the existing boolean API as a current-time wrapper.
Fixes #10