Repository navigation
fix: spatDeconvPlot() selects cell types by name, not position - #159
Merged
Merged
Conversation
The scatterpie layer took colnames(spatial_enrichment)[-1] as the pie columns, assuming cell_ID is first. DWLS writes cell_ID last, so it was passed to geom_scatterpie() and rowSums() failed. Exclude cell_ID by name. Fixes #149 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plot_spat_scatterpie_layer_ggplot()tookcolnames(spatial_enrichment)[-1]as the pie columns, which assumescell_IDis the first column. DWLS writescell_IDlast, socell_IDwas passed toscatterpie::geom_scatterpie()androwSums()failed with'x' must be numeric or complex.This picks the columns by name instead:
setdiff(colnames(spatial_enrichment), "cell_ID"). That matches how the same function already merges with the locations (by = "cell_ID"). Tables withcell_IDfirst behave exactly as before.tests/testthat/test_spat_deconv_plot.Rputscell_IDlast. It fails without the fix and passes with it.Same fix as the 0.2.15.1 patch PR into
main.Fixes #149
Reference to: #149 (comment)