Fixed compatibility issues when dragging the TabBar in Godot 4.6. - #42
Merged
Conversation
Owner
|
Hey @Yanxiyimengya, thanks for creating separate PRs for the fixes! The changes looks good to me (although I still have to test). I let the CI run, gdformat is saying that the code format does not conform to GDScript standard, could you please reformat the code using it to maintain consistency? |
Contributor
Author
Thank you for your reply. I have finished formatting the code and merged all the commits. |
gilzoide
approved these changes
Feb 22, 2026
Owner
|
Awesome, thanks a lot for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #39
The built-in TabBar component in Godot 4.6 hardcodes drag_data["type"] = "tab" in the C source code.
The old code strictly matches tab_container_tab or tabc_element, causing the _can_handle_drag_data function to return false directly, which blocks all drag-and-drop signals.
It's necessary to relax the type check and add compatibility for the tab_index key, which still works well in the editor from versions 4.4 to 4.6.