Skip to content

Fixed compatibility issues when dragging the TabBar in Godot 4.6. - #42

Merged
gilzoide merged 1 commit into
gilzoide:mainfrom
Yanxiyimengya:fix39
Feb 22, 2026
Merged

Fixed compatibility issues when dragging the TabBar in Godot 4.6.#42
gilzoide merged 1 commit into
gilzoide:mainfrom
Yanxiyimengya:fix39

Conversation

@Yanxiyimengya

Copy link
Copy Markdown
Contributor

Fixed #39

The built-in TabBar component in Godot 4.6 hardcodes drag_data["type"] = "tab" in the C source code.

The old code strictly matches tab_container_tab or tabc_element, causing the _can_handle_drag_data function to return false directly, which blocks all drag-and-drop signals.

It's necessary to relax the type check and add compatibility for the tab_index key, which still works well in the editor from versions 4.4 to 4.6.

@gilzoide

Copy link
Copy Markdown
Owner

Hey @Yanxiyimengya, thanks for creating separate PRs for the fixes!

The changes looks good to me (although I still have to test). I let the CI run, gdformat is saying that the code format does not conform to GDScript standard, could you please reformat the code using it to maintain consistency?

@Yanxiyimengya

Copy link
Copy Markdown
Contributor Author

Hey @Yanxiyimengya, thanks for creating separate PRs for the fixes!

The changes looks good to me (although I still have to test). I let the CI run, gdformat is saying that the code format does not conform to GDScript standard, could you please reformat the code using it to maintain consistency?

Thank you for your reply. I have finished formatting the code and merged all the commits.

@gilzoide
gilzoide merged commit e055fc4 into gilzoide:main Feb 22, 2026
2 checks passed
@gilzoide

Copy link
Copy Markdown
Owner

Awesome, thanks a lot for the contribution!
Cheers \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Layout is not working in Godot 4.6

2 participants