Updates - #250
Merged
Merged
Conversation
- fix lint warnings
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Concurrent get() callers waiting on an in-flight fetch resolved with empty content when the fetch failed. Now they throw the original error so onError fires for all callers. AbortError is filtered out so waiters don't reject on aborts they didn't trigger.
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes related to cache handling, concurrent requests, and testing infrastructure. The most significant changes include enhanced error handling for concurrent cache requests, improved test coverage for cache behaviors, and various dependency updates. Below are the most important changes grouped by theme.
Cache and Concurrency Improvements:
CacheStore: now, if a concurrent request fails, all waiting calls are properly rejected, ensuring consistent error propagation for in-flight requests.get()calls inCacheStoreare rejected if the underlying fetch fails.Testing Enhancements:
ReactInlineSVGinstances render their fallback content and callonErrorwhen a request fails, and that only a single fetch is performed.Code Quality and Refactoring:
processSVGlogic directly intogetNodeand removed the now-unusedprocessSVGfunction, simplifying the SVG processing code. [1] [2]omithelper to combine conditional checks for improved readability and performance.Dependency Updates:
package.json, includingeslint,prettier,react,jsdom, and testing tools, to their latest versions for improved tooling and compatibility.