Feat clean code with php code sniffer and phpstan level 6#2408
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
fa57ebc to
4782b1e
Compare
ac04efb to
bacff22
Compare
61e47de to
8ea8402
Compare
…ollers and models)
… add type hint # Conflicts: # protected/controllers/AdminAuthorController.php # protected/views/user/_form.php
8ea8402 to
6e8eee3
Compare
6e8eee3 to
980f717
Compare
Pull request for issue: #653, #2361
This is a pull request for the following functionalities:
clean code with php code sniffer and phpstan level 6
TODO:
phpstan.neon.dist
phpstan-boostrap.php.dist
documentation
implement automation: it will be in another PR
comment all broken delete method
why no direct access to:
problems:
Are excluded:
views: created1 or _form1 or updated1 => they are not used. Should we delete them?
How to test?
How have functionalities been implemented?
Any issues with implementation?
Any changes to automated tests?
Any changes to documentation?
Any technical debt repayment?
Any improvements to CI/CD pipeline?