Skip to content

Feat clean code with php code sniffer and phpstan level 6#2408

Draft
alli83 wants to merge 58 commits into
gigascience:developfrom
alli83:feat-clean-code-with-php-code-sniffer-and-phpstan-level-6
Draft

Feat clean code with php code sniffer and phpstan level 6#2408
alli83 wants to merge 58 commits into
gigascience:developfrom
alli83:feat-clean-code-with-php-code-sniffer-and-phpstan-level-6

Conversation

@alli83

@alli83 alli83 commented Jul 15, 2025

Copy link
Copy Markdown
Collaborator

Pull request for issue: #653, #2361

This is a pull request for the following functionalities:

clean code with php code sniffer and phpstan level 6

TODO:
phpstan.neon.dist
phpstan-boostrap.php.dist
documentation
implement automation: it will be in another PR
comment all broken delete method

why no direct access to:

  • AdminFileType?
  • AdminImages?

problems:

  • views for AdminImages are broken
  • form fields
  • Sample model: getSampleName method and $this->name property (where does it come from?)
  • Experiment model and class not found
  • inconsistencies for the rules in the models (e.g required)

Are excluded:
views: created1 or _form1 or updated1 => they are not used. Should we delete them?

How to test?

How have functionalities been implemented?

Any issues with implementation?

Any changes to automated tests?

Any changes to documentation?

Any technical debt repayment?

Any improvements to CI/CD pipeline?

@coderabbitai

coderabbitai Bot commented Jul 15, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@alli83
alli83 marked this pull request as draft July 15, 2025 07:31
@alli83
alli83 force-pushed the feat-clean-code-with-php-code-sniffer-and-phpstan-level-6 branch 2 times, most recently from fa57ebc to 4782b1e Compare July 16, 2025 07:26
@alli83
alli83 force-pushed the feat-clean-code-with-php-code-sniffer-and-phpstan-level-6 branch 5 times, most recently from ac04efb to bacff22 Compare July 24, 2025 07:00
@alli83
alli83 force-pushed the feat-clean-code-with-php-code-sniffer-and-phpstan-level-6 branch 3 times, most recently from 61e47de to 8ea8402 Compare July 29, 2025 15:35
@alli83 alli83 moved this to 👷 Work In Progress 👷‍♀️ in Current kanban board Aug 11, 2025
@alli83
alli83 force-pushed the feat-clean-code-with-php-code-sniffer-and-phpstan-level-6 branch from 8ea8402 to 6e8eee3 Compare August 20, 2025 13:07
@alli83
alli83 force-pushed the feat-clean-code-with-php-code-sniffer-and-phpstan-level-6 branch from 6e8eee3 to 980f717 Compare August 20, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants