Lookup and creator files for metnavaloft - #245
Merged
Merged
Conversation
camposeddie
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The granules in the collection are in ICARTT format, so I pulled in the icartt library for processing. There is a caveat that the icartt library requires a path-like, so the incoming stream is saved as a temp file. This works fine for these smaller files, but could be a pain point in the future if we have to process larger ICARTT files that hit ephemeral storage or runtime limitations.
That could potentially be sidestepped via a future ECS deployment of MDX (which is currently being worked on) or it might be worth considering submitting a merge request/issue to the icartt library. The offending lines that force a path-like in the icartt library can be found here.