Skip to content

fix: Allow spaces to be placed in SharedStrings file - #13

Merged
ghiscoding merged 1 commit into
mainfrom
bugfix/shared-strings-space
Feb 7, 2024
Merged

fix: Allow spaces to be placed in SharedStrings file#13
ghiscoding merged 1 commit into
mainfrom
bugfix/shared-strings-space

Conversation

@ghiscoding

Copy link
Copy Markdown
Owner

ref, original lib PR: stephenliberty/excel-builder.js#83

@codecov

codecov Bot commented Feb 7, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (af97f08) 55.8% compared to head (abf901e) 55.8%.

Files Patch % Lines
...s/excel-builder-vanilla/src/Excel/SharedStrings.ts 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #13     +/-   ##
=======================================
- Coverage   55.8%   55.8%   -0.0%     
=======================================
  Files         25      25             
  Lines       3080    3083      +3     
  Branches     240     240             
=======================================
  Hits        1718    1718             
- Misses      1361    1364      +3     
  Partials       1       1             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding
ghiscoding merged commit d416925 into main Feb 7, 2024
@ghiscoding
ghiscoding deleted the bugfix/shared-strings-space branch February 14, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant