Windows named pipes - #13
Open
yostinso wants to merge 3 commits into
Open
Conversation
So that the various Windows imports aren't required. Also don't allow the --pipe option on non-Windows platforms.
e.g. how to install pywin32 and a usage example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes quite a bit of code, but enables using Windows named pipes (via pywin32) for piping to Wireshark and other tools rather than having to jump through hoops with WSL2 or only being able to read from pcap files. I made an effort to avoid any additional requirements on non-Windows platforms.
See the updated README for the changes in behavior and requirements.