fix: remove unsafe eval() in TOP.js - #6
Open
anupamme wants to merge 1 commit into
Open
Conversation
Automated security fix generated by OrbisAI Security
|
@anupamme is attempting to deploy a commit to the ggg555ttt's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for moetalk ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
MoeScript/TOP.js.Vulnerability
V-001MoeScript/TOP.js:488Description: The developer options dialog contains a textarea labeled '代码注入' (code injection) that directly passes user-supplied content to eval(). This functionality is accessible to any user without authentication, allowing arbitrary JavaScript code execution in the application context.
Evidence
Exploitation scenario: User clicks '设置选项' → '开发者选项' → enters malicious JavaScript in the textarea → clicks '确认' → eval() executes the code in the application context, potentially stealing localStorage data, session.
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Changes
MoeScript/TOP.jsBehavior Preservation
The change is scoped to 1 file on the vulnerable path; it only tightens handling of untrusted input and leaves valid inputs unaffected.
Automated security fix by OrbisAI Security