[naga] Test validation of function/entry point name collision. - #9990
Merged
jimblandy merged 1 commit intoAug 3, 2026
Merged
Conversation
ErichDonGubler
approved these changes
Aug 3, 2026
ErichDonGubler
left a comment
ErichDonGubler
left a comment
Member
There was a problem hiding this comment.
Nice.
praise: The prose description for these test functions are nice, and I wish we did it in more places. It doesn't seem like something likely to bitrot.
ErichDonGubler
added
area: validation
jimblandy
force-pushed
the
naga-function-entry-point-name-uniqueness
branch
from
August 3, 2026 14:49
ec03a1d to
a1e643d
Compare
jimblandy
enabled auto-merge (rebase)
August 3, 2026 14:52
Unlike WGSL, Naga IR permits functions to have conflicting names, and entry points must only have distinct names if they are for the same shader stage. Document and test this.
jimblandy
force-pushed
the
naga-function-entry-point-name-uniqueness
branch
from
August 3, 2026 14:56
a1e643d to
619963d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike WGSL, Naga IR permits functions to have conflicting names, and entry points must only have distinct names if they are for the same shader stage. Document and test this.