Replace GlobalReport with per device wgt::Report that works via Tracing - #9952
Open
sagudev wants to merge 1 commit into
Open
Replace GlobalReport with per device wgt::Report that works via Tracing#9952sagudev wants to merge 1 commit into
GlobalReport with per device wgt::Report that works via Tracing#9952sagudev wants to merge 1 commit into
Conversation
sagudev
marked this pull request as ready for review
July 28, 2026 11:18
inner-daemons
self-requested a review
July 29, 2026 15:41
8 tasks
…racing Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Collaborator
Author
|
Rebased and resolved conflicts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
For #9950 and towards #5121
Description
In #9950 I discovered that we need
GlobalReportfor some memory leak tests. One option is to completely remove all such uses and tests (I wonder how useful they are anyway). This PR goes into alternative route by impl reporting as part of tracing (which gives us most of Creates/Drops). Tracing is per device not per instance, so some stuff is unimplementable (so is removed from test), some stuff are not traced yet so they are commented out. Still I think the most important part of mem leak test was kept.Testing
Covered by tests.
Squash or Rebase?
Squash
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.