Skip to content

Replace GlobalReport with per device wgt::Report that works via Tracing - #9952

Open
sagudev wants to merge 1 commit into
gfx-rs:trunkfrom
sagudev:reports
Open

Replace GlobalReport with per device wgt::Report that works via Tracing#9952
sagudev wants to merge 1 commit into
gfx-rs:trunkfrom
sagudev:reports

Conversation

@sagudev

@sagudev sagudev commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Connections
For #9950 and towards #5121

Description
In #9950 I discovered that we need GlobalReport for some memory leak tests. One option is to completely remove all such uses and tests (I wonder how useful they are anyway). This PR goes into alternative route by impl reporting as part of tracing (which gives us most of Creates/Drops). Tracing is per device not per instance, so some stuff is unimplementable (so is removed from test), some stuff are not traced yet so they are commented out. Still I think the most important part of mem leak test was kept.

Testing
Covered by tests.

Squash or Rebase?
Squash

Checklist

  • I self-reviewed and fully understand this PR.
  • WebGPU implementations built with wgpu may be affected behaviorally.
  • Validation and feature gates are in place to confine behavioral changes.
  • Tests demonstrate the validation and altered logic works.
  • CHANGELOG.md entries for the user-facing effects of this change are present.
  • The PR is minimal, and doesn't make sense to land as multiple PRs.
  • Commits are logically scoped and individually reviewable.
  • The PR description has enough context to understand the motivation and solution implemented.

@sagudev
sagudev marked this pull request as ready for review July 28, 2026 11:18
@inner-daemons
inner-daemons self-requested a review July 29, 2026 15:41
@inner-daemons inner-daemons self-assigned this Jul 29, 2026
@Wumpf Wumpf assigned Wumpf and inner-daemons and unassigned inner-daemons Jul 29, 2026
…racing

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
@sagudev

sagudev commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator Author

Rebased and resolved conflicts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants