Conversation
Vecvec
force-pushed
the
tlas-instance-more-constructors
branch
from
September 27, 2026 22:55
11bbe07 to
81aaf8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
None
Description
I almost never use the more complex parts of tlas instances, and frequently don't use transforms. This makes it painful to write tlas instance building in simple cases, and also annoying to read and debug the code (I've used NSight and PIX more often to debug why my instances aren't showing up [and then finding that is was because I had mis-typed my matrix so that they were a point or I had swapped the mask and custom data] than any other problem). I think it makes sense to add functions for two common simple uses - a full mask and no custom data + a blas + transform and a full mask and no custom data with identity transform + a blas. This can also help prevent breaking changes as things like new flags and instance intersection group indices can be left out of these new functions.
The names are a bit more annoying. Hopefully this can all be reworked w/ default field values, but that still seems to be some time away.
Testing
Changed most tests to use these where possible.
Squash or Rebase?
Squash
LLM Use?
None
Checklist
CHANGELOG.mdentries for the user-facing effects of this change are present.