Skip to content

Add convience functions for creating TlasInstances - #10476

Open
Vecvec wants to merge 3 commits into
gfx-rs:trunkfrom
Vecvec:tlas-instance-more-constructors
Open

Vecvec wants to merge 3 commits into
gfx-rs:trunkfrom
Vecvec:tlas-instance-more-constructors

Conversation

@Vecvec

@Vecvec Vecvec commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Connections

None

Description

I almost never use the more complex parts of tlas instances, and frequently don't use transforms. This makes it painful to write tlas instance building in simple cases, and also annoying to read and debug the code (I've used NSight and PIX more often to debug why my instances aren't showing up [and then finding that is was because I had mis-typed my matrix so that they were a point or I had swapped the mask and custom data] than any other problem). I think it makes sense to add functions for two common simple uses - a full mask and no custom data + a blas + transform and a full mask and no custom data with identity transform + a blas. This can also help prevent breaking changes as things like new flags and instance intersection group indices can be left out of these new functions.

The names are a bit more annoying. Hopefully this can all be reworked w/ default field values, but that still seems to be some time away.

Testing

Changed most tests to use these where possible.

Squash or Rebase?

Squash

LLM Use?

None

Checklist

  • I self-reviewed and fully understand this PR.
  • CHANGELOG.md entries for the user-facing effects of this change are present.
  • The PR is minimal, and doesn't make sense to land as multiple PRs.
  • Commits are logically scoped and individually reviewable.
  • The PR description has enough context to understand the motivation and solution implemented.

@Vecvec
Vecvec force-pushed the tlas-instance-more-constructors branch from 11bbe07 to 81aaf8a Compare September 27, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To triage

Development

Successfully merging this pull request may close these issues.

1 participant