Repository navigation
v0.3.2 — report link-scheme hardening & trace-link honesty - #2
Merged
Merged
Conversation
The HTML report assigns result.json values (finding url, cluster member url, plan url, page url, header entry) directly to anchor `href`. The bundled scanner only ever produces http(s) URLs, but renderHtml is a general generator over an arbitrary ScanResult, so a crafted / shared / older / third-party result.json opened as an offline report could make a page link `javascript:` or `data:` — self-XSS on click. Reproduced: a rendered report exposed live `javascript:alert(member)` anchors. - Client: safeHref() + linkOrText() emit an anchor only for http(s); anything else renders as non-clickable muted text. Applied to the four dynamic link sites (member, finding, plan "Open …", page table). - Server: httpHref() guards the header target anchor. - Trace links stay local/private but now say so (label + title: traces are not included in hosted/public copies) so users stop expecting a web download of stripped evidence. Tests: real-browser audit asserts zero javascript:/data:/file: anchors while legitimate http(s) links still render; unit tests cover the header guard and the trace-copy honesty.
Bump 0.3.1 -> 0.3.2 (package.json, lock, runtime VERSION). Add the v0.3.2 CHANGELOG entry (report link-scheme hardening + trace-link honesty), update the README (en + zh) Status sections and refresh the compatibility matrix with the real verified counts (136/136) and observed v0.3.1 CI results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-release hardening on the verified v0.3.1 base.
hrefwith no scheme check; a crafted/shared/older result.json opened as an offline report could yield ajavascript:/data:link (self-XSS). All dynamic links (member/finding/plan/page) + the header target now validate http(s); unsafe URLs render as text. Reproduced (live javascript: anchors) then fixed.Head: 673275f