CF-16340: fix(deps): upgrade shell-quote to 1.8.4 to fix vulnerability GHSA-w7jw-789q-3m8p#218
Draft
midnight-clue[bot] wants to merge 1 commit into
Draft
CF-16340: fix(deps): upgrade shell-quote to 1.8.4 to fix vulnerability GHSA-w7jw-789q-3m8p#218midnight-clue[bot] wants to merge 1 commit into
midnight-clue[bot] wants to merge 1 commit into
Conversation
…w-789q-3m8p Co-Authored-By: victor.persien <victor.persien@getyourguide.com>
gyg-pr-tool
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes critical security vulnerability GHSA-w7jw-789q-3m8p in the
shell-quotepackage. Thequote()function did not escape newlines in object.opvalues (affected range >= 1.1.0, <= 1.8.3).shell-quotewas a transitive (dev-scope) dependency pinned at 1.8.3.Change
pnpm.overridesentry inpackage.json:"shell-quote@>=1.1.0 <1.8.4": "1.8.4"to force the patched version for all consumers.pnpm-lock.yamlviapnpm install;shell-quotenow resolves to 1.8.4.Verification
grep 'shell-quote@' pnpm-lock.yamlshows 1.8.4 and no 1.8.3-or-lower entries remain.pnpm installcompletes without errors.References
🤖 Claude session