Repository navigation
feat(tools): Return reporter name, email, and IP from get_issue_user_reports - #2033
Merged
Merged
Conversation
…reports The tool collapsed the report and event user into one display string. Return the report name and email, plus the event user's id, username, name, email, and IP address, as separate fields. Co-Authored-By: David Cramer <23610+dcramer@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
…ail or username Sentry fills report and event-user names from the email or username when no real name exists. Return null for those so name holds only a real name. Co-Authored-By: David Cramer <23610+dcramer@users.noreply.github.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_issue_user_reports(#1997) collapsed the report name, report email, and event user into onereporterdisplay string, and its test asserted the event user's IP address stayed out. User data Sentry stored should come back to the caller, so this returns it as explicit fields.Each report now has:
nameandemail: from the report, falling back to the event user. This matches the Sentry serializer (userreport.py), which already fills these from the event user.user:{ id, username, name, email, ipAddress }from the linked event user, ornullwhen there is none. Empty strings and the legacy"None"/"null"id sentinels map tonull.namefrom the email (obj.name or obj.email) and the event user's name fromget_display_name(), which falls back to email and then username. Sonameanduser.namearenullwhen they only repeat the email or username.reporteris removed because the explicit fields replace it.avatarUrland the nestedeventobject stay out.Tests use Sentry-shaped fixtures. They assert the email, username, and IP address come through, that names copied from the email or username map to
null, and that the empty event-user shell maps tonull.Checks, all with
SENTRY_AUTH_TOKENunset: generate-definitions, mcp-core tsc, full mcp-core vitest (2116 passed, 6 skipped), and root lint. If this rebases over another tool PR, regeneratetoolDefinitions.json.via @dcramer.
--
View Session [Sentry]