Repository navigation
meta: Use Craft's post-release bump and bump Craft to 3.9.0 - #8649
Merged
Merged
Conversation
Craft 3.7.0 can bump to the next development version after a release (postReleaseBump), so the hand-written post-release script is no longer needed. Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
BYK
approved these changes
Nov 2, 2026
BYK
requested changes
Nov 2, 2026
Craft releases before 3.7.0 silently drop the unknown postReleaseBump key, so the post-release dev version bump would be skipped. Raise minVersion so older Craft fails fast, and pin the prepare action to 3.7.0 to match. Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
BYK
approved these changes
Nov 2, 2026
BYK
enabled auto-merge (squash)
November 2, 2026 12:34
ElioDiNino
approved these changes
Nov 2, 2026
3.9.0 includes getsentry/craft#956, which stops the release when release-blocker issues are open.
Contributor
Author
|
I bumped the craft pin in this PR from 3.7.0 to 3.9.0 ( |
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f706803. Configure here.
BYK
approved these changes
Nov 3, 2026
mchen-sentry
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Craft 3.7.0 can set the next development version itself after a release (
postReleaseBump). This replacesscripts/post-release.shwith it.postReleaseBump.version: '{{version}}.dev0'gives the same result as the olddatearithmetic:26.10.1becomes26.11.0.dev0, and26.12.xbecomes27.1.0.dev0. Craft commits it asmeta: Bump new development versionand adds#skip-changelog.preReleaseCommand: bash scripts/bump-version.shis now explicit. Craft writes the development version through the pre-release command. Without one,minVersion≥ 2.21 tries the automatic target bumps, and docker/github can't bump anything.craft prepare, so release commits will now set the release version inpyproject.toml,uv.lockanddocs/source/conf.py. Until nowprepareskippedbump-version.shbecause of the automatic bump path, so26.10.1shipped with26.11.0.dev0inpyproject.toml.2e29b081, previously 2.34.13f2abdc5). Before 3.9.0, the "Check release blockers" step asked GitHub to cancel the run and then exited 0, so a release could still go ahead whilerelease-blockerissues were open (example in getsentry/symbolic). fix(action): Stop the release when release-blocker issues are open craft#956 fixed that in 3.9.0. This PR also replaces Dependabot's build(deps): Bump getsentry/craft from 2.34.1 to 3.4.0 #8648 (which bumps only to 3.4.0).I checked the config against Craft 3.7.0's schema, and ran
bump-version.shon a copy for both the release and the dev version.Config changes:
minVersion"3.7.0" → "3.9.0".preReleaseCommandis already explicit (see above). craft 3.9.0'sprepare 99.0.0 --dry-rungave the same result before and after this change: it runsbump-version.shand bumpspyproject.toml,uv.lock,docs/source/conf.pyandCHANGELOG.md. Norelease-blockerissues are open in this repo.via @BYK.
--
View Session in Sentry