Skip to content

meta: Use Craft's post-release bump and bump Craft to 3.9.0 - #8649

Merged
BYK merged 4 commits into
masterfrom
meta/use-post-release-bump
Nov 3, 2026
Merged

BYK merged 4 commits into
masterfrom
meta/use-post-release-bump

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Craft 3.7.0 can set the next development version itself after a release (postReleaseBump). This replaces scripts/post-release.sh with it.

  • postReleaseBump.version: '{{version}}.dev0' gives the same result as the old date arithmetic: 26.10.1 becomes 26.11.0.dev0, and 26.12.x becomes 27.1.0.dev0. Craft commits it as meta: Bump new development version and adds #skip-changelog.
  • preReleaseCommand: bash scripts/bump-version.sh is now explicit. Craft writes the development version through the pre-release command. Without one, minVersion ≥ 2.21 tries the automatic target bumps, and docker/github can't bump anything.
  • Behavior change: the explicit command also runs during craft prepare, so release commits will now set the release version in pyproject.toml, uv.lock and docs/source/conf.py. Until now prepare skipped bump-version.sh because of the automatic bump path, so 26.10.1 shipped with 26.11.0.dev0 in pyproject.toml.
  • The release workflow now pins Craft 3.9.0 (2e29b081, previously 2.34.1 3f2abdc5). Before 3.9.0, the "Check release blockers" step asked GitHub to cancel the run and then exited 0, so a release could still go ahead while release-blocker issues were open (example in getsentry/symbolic). fix(action): Stop the release when release-blocker issues are open craft#956 fixed that in 3.9.0. This PR also replaces Dependabot's build(deps): Bump getsentry/craft from 2.34.1 to 3.4.0 #8648 (which bumps only to 3.4.0).

I checked the config against Craft 3.7.0's schema, and ran bump-version.sh on a copy for both the release and the dev version.

Config changes: minVersion "3.7.0" → "3.9.0". preReleaseCommand is already explicit (see above). craft 3.9.0's prepare 99.0.0 --dry-run gave the same result before and after this change: it runs bump-version.sh and bumps pyproject.toml, uv.lock, docs/source/conf.py and CHANGELOG.md. No release-blocker issues are open in this repo.

via @BYK.

--

View Session in Sentry

Craft 3.7.0 can bump to the next development version after a release
(postReleaseBump), so the hand-written post-release script is no longer
needed.

Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
@sentry-junior
sentry-junior Bot requested review from a team as code owners November 2, 2026 12:07
Comment thread .craft.yml Resolved
Craft releases before 3.7.0 silently drop the unknown postReleaseBump
key, so the post-release dev version bump would be skipped. Raise
minVersion so older Craft fails fast, and pin the prepare action to
3.7.0 to match.

Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
@BYK
BYK enabled auto-merge (squash) November 2, 2026 12:34
3.9.0 includes getsentry/craft#956, which stops the release when
release-blocker issues are open.
@sentry-junior

sentry-junior Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

I bumped the craft pin in this PR from 3.7.0 to 3.9.0 (2e29b081), which includes getsentry/craft#956. That fix stops the release when release-blocker issues are open; before it, craft only asked GitHub to cancel the run and kept going (example). craft 3.9.0 loads this branch's .craft.yml (with postReleaseBump) without errors. minVersion: 3.7.0 stays as it is. This PR also replaces Dependabot's #8648 (→ 3.4.0).

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread .github/workflows/release.yml Resolved
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f706803. Configure here.

Comment thread .craft.yml Resolved
@sentry-junior sentry-junior Bot changed the title meta: Use Craft's built-in post-release version bump meta: Use Craft's post-release bump and bump Craft to 3.9.0 Nov 3, 2026
@BYK
BYK merged commit c4a1d60 into master Nov 3, 2026
71 checks passed
@BYK
BYK deleted the meta/use-post-release-bump branch November 3, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants