Repository navigation
Conversation
update_allocation_policies_balances only ran when an endpoint recorded a query_result or the error was a QueryException / RPCAllocationPolicyException. Every request takes a concurrency slot in get_quota_allowance, so endpoints that never set query_result (GetTrace, GetTraces, TraceItemDetails, ExportTraceItems, DeleteTraceItems, AttributeNames, AttributeValues, CreateSubscription) and every timeout (re-raised as an RPCRequestException) held their slot until max_query_duration_s expired. Run the update for every request, with a zero-bytes placeholder result when the endpoint recorded none. Also keep the ClickHouse error as the cause of the re-raised timeout so BytesScannedRejectingPolicy charges its timeout penalty.
…equest" This reverts commit be0dbbd.
…cy slot With a concurrency limit of 1, a second trace item table request runs, but a second attribute names request is rejected because the first one, which never records a query result, still holds its slot.
dezzeddi
changed the title
dezzeddi
marked this pull request as ready for review
November 3, 2026 23:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test showing that RPC endpoints which never record a query result don't release their concurrency slot. The leaking case fails on master.
ConcurrentRateLimitAllocationPolicyat a limit of 1, a second trace item table request runs (passes).