Repository navigation
ci(release): Bump craft to 3.9.0 and update config - #1383
Open
sentry-junior[bot] wants to merge 2 commits into
Open
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the release workflow's pinned
getsentry/craftaction from 2.19.0 (c6e2f049, labeled# v2) to 3.9.0 (2e29b081).Why: craft's "Check release blockers" step used to ask GitHub to cancel the run and then exit 0, so the action kept going and could still prepare a release and open a getsentry/publish issue while a
release-blockerissue was open (seen in getsentry/symbolic). getsentry/craft#956 fixed this in 3.9.0: the step now fails right away, and it also fails if the blocker lookup errors.Compatibility with craft 3.x:
version,force,merge_target,craft_config_from_merge_target) all still exist in 3.9.0; releases between only added optional inputs..craft.ymldoesn't setchangelog.includePaths/unownedPaths, there's no nuget target, and it definespreReleaseCommand, so the new "fail when auto-bump finds nothing" check doesn't run.prepare 99.0.0 --dry-run --no-pushon currentmaster. It ranscripts/craft-pre-release.sh, bumpedpackage.jsonandsrc/version.ts, and finished without errors.There are no open
release-blockerissues in this repo right now. Once this lands, any open one stops releases until it's closed orforceis set.No changelog entry, since this is CI-only.
Config changes (follow-up commit, so
.craft.ymlmatches craft 3.9.0):Sets
minVersionfrom 2.17.0 to 3.9.0. Nothing else needs to change, sincepreReleaseCommandandchangelog.policyare already explicit and theautoversioning default stays the same.I ran craft 3.9.0
prepare 99.0.0 --dry-run --no-pushbefore and after this change on a full clone. Both runs bumpedpackage.jsonandsrc/version.tswith no new warnings or errors.via @BYK.
--
View Session in Sentry