feat(client-reports): Add transport loss recorder#1158
Open
szokeasaurusrex wants to merge 2 commits into
Open
Conversation
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-report-recorder
branch
from
d773421 to
a3a0645
Compare
szokeasaurusrex
changed the title
|
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-report-recorder
branch
2 times, most recently
from
b06abcc to
11aeb31
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-report-recorder
branch
2 times, most recently
from
70d4273 to
2c18ec2
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/client-report-aggregator
branch
2 times, most recently
from
08adad0 to
ce47300
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-report-recorder
branch
from
2c18ec2 to
d6c1636
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/client-report-aggregator
branch
from
ce47300 to
cd4d502
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-report-recorder
branch
from
397f1c3 to
dd2269e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dd2269e. Configure here.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-report-recorder
branch
from
dd2269e to
c349e74
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/client-report-aggregator
branch
2 times, most recently
from
2fd0c53 to
3f24715
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-report-recorder
branch
from
c349e74 to
1c48443
Compare
Add a public `ClientReportRecorder` handle for transports to record lost Sentry data without exposing the full client-report aggregator. Pass the recorder through `TransportOptions` when the SDK client builds a transport. Recorded losses are aggregated into future `client_report` envelope items, so transports can report drops without sending extra requests. Keep backwards-compatible transport construction paths working by using a no-op recorder when no client-report aggregator is available. Built-in transports will start calling the recorder in follow-up PRs. Resolves [#1148](#1148) Resolves [RUST-223](https://linear.app/getsentry/issue/RUST-223)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/client-report-aggregator
branch
from
3f24715 to
3438068
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-report-recorder
branch
from
1c48443 to
e8d437b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a public
ClientReportRecorderhandle for transports to record lost Sentry data without exposing the full client-report aggregator.Pass the recorder through
TransportOptionswhen the SDK client builds a transport. Recorded losses are aggregated into futureclient_reportenvelope items, so transports can report drops without sending extra requests.Keep backwards-compatible transport construction paths working by using a no-op recorder when no client-report aggregator is available. Built-in transports will start calling the recorder in follow-up PRs.
Resolves #1148
Resolves RUST-223