Skip to content

perf: Avoid scanning installed packages in package_version #8191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jackevansevo wants to merge 3 commits into
base: master
Choose a base branch
from
+19 −0
Open

perf: Avoid scanning installed packages in package_version #8191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea2c4c6
perf: Avoid scanning installed packages in package_version
Jackevansevo Nov 5, 2026
f47e6a4
fix: Fall back to the existing lookup when package metadata is broken
Jackevansevo Nov 5, 2026
06ac994
test: Skip the package_version scan test below Python 3.8
Jackevansevo Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sentry_sdk/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1837,6 +1837,16 @@ def _get_installed_modules() -> "Dict[str, str]":


def package_version(package: str) -> "Optional[Tuple[int, ...]]":
try:
from importlib import metadata

metadata_version = metadata.version(package)
if metadata_version is not None:
return parse_version(metadata_version)
except Exception:
# < py3.8, or missing or broken metadata for this package
pass

normalized_package = _normalize_module_name(
_replace_hyphens_dots_and_underscores_with_dashes(package)
)
Expand Down
9 changes: 9 additions & 0 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,6 +1412,15 @@ def test_package_version_is_none():
assert package_version("non_existent_package") is None


@pytest.mark.skipif(sys.version_info < (3, 8), reason="requires importlib.metadata")
def test_package_version_does_not_scan_installed_packages():
with mock.patch("sentry_sdk.utils._generate_installed_modules") as generate:
with mock.patch("sentry_sdk.utils._installed_modules", None):
assert package_version("pytest") is not None

generate.assert_not_called()
Comment thread
cursor[bot] marked this conversation as resolved.
Resolved


@pytest.mark.parametrize(
"kwargs, expected",
[
Expand Down