Repository navigation
feat(solidstart): Export withSentry from @sentry/solidstart/vite - #25725
Conversation
isaacs
requested review from
chargome and
s1gr1d
and removed request for
a team
October 23, 2026 21:20
Contributor
Optional E2E testsAll optional checks were successful. 1 successful. See the run. Successful checks
|
Contributor
size-limit report 📦Compared: 207e9f7 (PR test merge using develop at 0341c0b) Against: 30cfb4c (develop) · base run #64245
|
nicohrubec
approved these changes
Oct 28, 2026
nicohrubec
reviewed
Oct 28, 2026
nicohrubec
left a comment
nicohrubec
left a comment
Member
There was a problem hiding this comment.
lgtm, we should also update the docs to use the new setup and add a ticket to the v12 milestone
isaacs
requested review from
andreiborza,
logaretm,
msonnb and
mydea
and removed request for
a team
October 29, 2026 17:58
`withSentry` wraps the SolidStart config at build time. The root entry re-exports it, so the server runtime entry reaches `@sentry/bundler-plugins` and the orchestrion rollup transform. Any tool that traces or bundles the server entry then pulls that tooling in. `withSentry` now also comes from `@sentry/solidstart/vite`, next to the Vite plugin. The root export stays, deprecated, until the next major version, so existing `app.config.ts` files keep working. The E2E apps use the new path. Refs #25676 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
isaacs
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Oct 29, 2026
This was referenced Oct 29, 2026
isaacs
force-pushed
the
isaacschlueter/js-3989-guard-server-runtime-entries-against-pulling-in-build-time-solidstart
branch
from
October 29, 2026 18:12
e799694 to
4494191
Compare
isaacs
enabled stacked auto-merge (squash)
October 30, 2026 19:08
isaacs
deleted the
isaacschlueter/js-3989-guard-server-runtime-entries-against-pulling-in-build-time-solidstart
branch
October 30, 2026 21:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withSentrywraps the SolidStart config at build time. The root entry re-exports it, so the server runtime entry reaches@sentry/bundler-pluginsand the orchestrion rollup transform. Any tool that traces or bundles the server entry then pulls that tooling in.withSentrynow also comes from@sentry/solidstart/vite, next to the Vite plugin. The root export stays, deprecated, until the next major version, so existingapp.config.tsfiles keep working. The E2E apps use the new path.Refs #25676
Stack created with GitHub Stacks CLI • Give Feedback 💬