Repository navigation
feat(bundler-plugins): Enable hidden source maps and remove them after upload in the Vite plugin - #25646
Draft
timfish wants to merge 1 commit into
Conversation
timfish
added this pull request to stack #25649
October 22, 2026 10:47
Contributor
size-limit report 📦Compared: 5ffc305 (PR test merge using develop at b506034) Against: 8042719 (develop) · base run #63102
|
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 22, 2026 10:57
ac0df2a to
6546bd8
Compare
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 failing, 63 successful. See the run.
Successful checks
|
…r upload in the Vite plugin The Vite plugin decides on `build.sourcemap` in its `config` hook, because Vite warns about `rollupOptions.output.sourcemap`, and maps the decision onto each environment's output directory in `configResolved`. The post plugin that restores debug IDs for `disable-upload` builds is now always present and also stages the source maps for upload.
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 22, 2026 11:49
6546bd8 to
30717e0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the stack for #25609. Vite warns about
rollupOptions.output.sourcemap, so the Vite plugin decides onbuild.sourcemapin itsconfighook and maps the decision onto each environment's output directory inconfigResolved, including directories set throughrollupOptions.output.dir. A later plugin that turns source maps off again disables the deletion for that environment.The post plugin that restores debug IDs for
disable-uploadbuilds is now always present and also stages the source maps, after Vite's import analysis has regenerated them.