Skip to content

test(cloudflare): Request workers over IPv4 in integration tests - #25506

Closed
mydea wants to merge 1 commit into
developfrom
fix/cloudflare-integration-ipv4-worker-url
Closed

mydea wants to merge 1 commit into
developfrom
fix/cloudflare-integration-ipv4-worker-url

Conversation

@mydea

@mydea mydea commented Oct 19, 2026

Copy link
Copy Markdown
Member

Fixes a flaky Cloudflare integration test failure like Expected request to "/queue/send" to succeed, but got a 500 response: Not yet implemented.

wrangler/workerd binds the worker port only on 127.0.0.1 (IPv4 and IPv6 listeners each get their own port-0 assignment). The runner requested http://localhost:<port>, which Node tries on ::1 first — normally refused, then falling back to IPv4. But when another wrangler's inspector happens to hold [::1]:<same port>, the request lands there, and workerd's inspector answers any unknown path with 500 "Not yet implemented". Requesting 127.0.0.1 directly avoids the ambiguity; the startSpan test's host/URL assertions are updated accordingly.

🤖 Generated with Claude Code

wrangler only binds the worker port on 127.0.0.1, so requesting `localhost`
(which resolves to ::1 first) could connect to another wrangler's inspector
that happened to get the same port number on ::1, failing with a 500
"Not yet implemented".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mydea
mydea marked this pull request as ready for review October 19, 2026 08:51
@mydea
mydea requested a review from a team as a code owner October 19, 2026 08:51
@mydea
mydea requested review from JPeer264 and isaacs and removed request for a team October 19, 2026 08:51
@JPeer264

Copy link
Copy Markdown
Member

@mydea

mydea commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

I think it is better if we keep it and fix it by adding this: https://github.com/getsentry/sentry-javascript/pull/25508/changes#diff-b2cf573a93bbfe5d7150cb2b0b02bb40a6e35dc9f7ad1031cdf018287cf317f4

wdyt?

also fine by me, I'll close this then! :)

@mydea mydea closed this Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants