Repository navigation
test(v10): Skip Vercel AI OTel multi-step test on Node 26.12+ - #25443
Merged
Merged
Conversation
Co-Authored-By: GPT-6 <codex@openai.com>
Contributor
size-limit report 📦
|
nicohrubec
marked this pull request as ready for review
October 16, 2026 11:06
nicohrubec
requested review from
isaacs and
mydea
and removed request for
a team
October 16, 2026 11:06
JPeer264
approved these changes
Oct 16, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
Wouldn't it be good to fix that then on v10
s1gr1d
approved these changes
Oct 16, 2026
Member
Author
|
@JPeer264 ideally yes but not sure if its worth it, I think we can wait if people report this and if "please upgrade to v11" is not an option then we can take another look wdyt? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 26.12 changes Web Streams completion callbacks' async context, causing Vercel AI v6's second streamed model call to inherit the first call as its parent. This also makes v10's token aggregation overwrite the correct agent totals.
I suggest to skip this test for the affected Node 26 versions since this only affects our old OTel path, which we no longer maintain but this currently blocks v10 CI.