Repository navigation
fix(v10/core): Don't mark http client spans as errors when the caller aborts - #25431
Merged
Merged
Conversation
… aborts Backport of: #25260
Contributor
size-limit report 📦
|
nicohrubec
approved these changes
Oct 16, 2026
nicohrubec
marked this pull request as ready for review
October 16, 2026 07:39
nicohrubec
enabled auto-merge (squash)
October 16, 2026 08:19
andreiborza
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #25260
Differences to the original PR
packages/core/test/lib/integrations/http/client-subscriptions.test.ts: assertions use v10's span status values (undefinedfor success,not_found/internal_errorfor failures instead ofok/error) and select spans byop === 'http.client'. Source changes are identical to the original.This branch was prepared by the v10 backport automation, which was blocked at PR creation; it's opened manually now.
via Jan Peer Stöcklmair.
--
View Junior Session in Sentry