Repository navigation
Conversation
mydea
added this pull request to stack #25405
October 15, 2026 12:55
mydea
force-pushed
the
ci/e2e-without-root-node-modules
branch
from
October 15, 2026 14:28
64925fb to
f0bf393
Compare
mydea
force-pushed
the
ci/e2e-without-root-node-modules
branch
from
October 16, 2026 07:35
f0bf393 to
0113a54
Compare
E2E jobs restored the ~860 MB root dependency cache and the full build output only to run a few tsx scripts and to resolve the linked test-utils package. The scripts are now plain .mjs files without dependencies, and test-utils is installed from a tarball like the SDK packages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With all scripts as plain .mjs files, the local runner no longer needs tsx, dotenv or glob. esbuild was unused. Type checking of this package was never run in CI, so it no longer has a tsconfig; the JSDoc types are kept for editors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
force-pushed
the
ci/e2e-without-root-node-modules
branch
from
October 16, 2026 08:52
0113a54 to
c3e497e
Compare
… jobs Only the E2E jobs drop the root node_modules, so only they need another way to get pnpm. Canary, Lighthouse and local runs keep getting it through yarn.lock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
marked this pull request as ready for review
October 16, 2026 11:18
msonnb
approved these changes
Oct 16, 2026
andreiborza
approved these changes
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each E2E job restored the full ~860 MB root dependency cache and the build output (about 33s per job, ~2.5 runner-hours per CI run) only to run a few
tsxscripts and to resolve@sentry-internal/test-utils. Since #25402 installs test-utils from a tarball, E2E jobs now only download tarballs.The E2E scripts are now plain
.mjsfiles without dependencies. They run under each app's pinned Node (down to 20.19), which rules out Node's type stripping. Withrun.tsconverted too, the package no longer needstsx,dotenv,glob,esbuildor a tsconfig (lint:tsnever ran in CI).Since #25380 the Playwright install reads its version from the app's
package.json, so it doesn't need the rootnode_moduleseither. Since #25334,install-pnpmtakes pnpm from the rootnode_modulestoo, so the E2E jobs install the rootdevDependenciesversion withpnpm/action-setupinstead. Other workflows and local runs keep getting pnpm throughyarn.lock.aws-serverlessstill downloads the build output, since its Lambda stack installs the built package directories.Stacked on #25402. Replaces #25371, which GitHub closed as merged by accident during a restack. Its review history is still there.
🤖 Generated with Claude Code