Skip to content

fix(server-utils): Stop treating previous_response_id as the OpenAI conversation id - #25269

Merged
RulaKhaled merged 1 commit into
developfrom
fix/openai-previous-response-id-not-conversation
Oct 12, 2026
Merged

RulaKhaled merged 1 commit into
developfrom
fix/openai-previous-response-id-not-conversation

Conversation

@RulaKhaled

Copy link
Copy Markdown
Collaborator

The OpenAI integration filled gen_ai.conversation.id from previous_response_id. That id names the previous response, so it changes on every turn and never groups two spans. Same flaw #24979 removed from Vercel AI, flagged there by isaacs.

The id now comes only from the Conversations API: the conversation request parameter or a conversations.create() response. The response's own id stays on gen_ai.response.id.

Part of #24832

🤖 Generated with Claude Code

…onversation id

The OpenAI integration filled `gen_ai.conversation.id` from
`previous_response_id`. That id names the previous response, so it changes
on every turn and never groups two spans. The id now comes only from the
Conversations API: the `conversation` request parameter or a
`conversations.create()` response.

Part of #24832

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@RulaKhaled
RulaKhaled marked this pull request as ready for review October 12, 2026 11:53
@RulaKhaled
RulaKhaled requested a review from a team as a code owner October 12, 2026 11:54
@RulaKhaled
RulaKhaled requested review from andreiborza, isaacs and mydea and removed request for a team October 12, 2026 11:54

@andreiborza andreiborza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@RulaKhaled
RulaKhaled merged commit b80300b into develop Oct 12, 2026
546 of 548 checks passed
@RulaKhaled
RulaKhaled deleted the fix/openai-previous-response-id-not-conversation branch October 12, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants