Repository navigation
test(browser): Register the LCP handlers in the bundle of the SDK - #25263
Merged
chargome merged 1 commit intoOct 12, 2026
Merged
Conversation
The handlers lived in the subject bundle, which got its own copy of the instrumentation and so an LCP observer of its own. On Linux CI that copy sometimes only ever saw the body candidate while the SDK's copy saw the image, so the handler assertions failed on every run of some trees and timed out in others. In the bundle of the SDK the handlers share its observer and see exactly what the span reports. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
chargome
marked this pull request as ready for review
October 12, 2026 11:22
chargome
requested review from
a team,
logaretm,
msonnb and
nicohrubec
and removed request for
a team
October 12, 2026 11:22
msonnb
approved these changes
Oct 12, 2026
chargome
deleted the
chargome/test/browser-lcp-handlers-shared-observer
branch
October 12, 2026 11:31
47 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flaky test. The
handlers-lcptest registered its LCP handlers in a separate bundle, so they watched LCP through their own observer and sometimes saw a different element than the SDK did on Linux CI. Now the handlers are registered in the same bundle as the SDK, so they see exactly what the SDK sees.