Repository navigation
fix(nuxt): Remove @opentelemetry/resources dev alias - #25216
Merged
Merged
Conversation
The alias ended up in the generated .nuxt tsconfig paths as a non-relative path, which vue-tsc rejects when typeCheck is enabled. Nothing in the Nuxt SDK's dependency tree uses @opentelemetry/resources anymore, so the alias is no longer needed. Fixes #25188 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 54e7000. Configure here.
chargome
marked this pull request as ready for review
October 9, 2026 10:15
chargome
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
October 9, 2026 10:15
nicohrubec
approved these changes
Oct 9, 2026
| @@ -0,0 +1,40 @@ | |||
| import type { Nuxt } from '@nuxt/schema'; | |||
Member
There was a problem hiding this comment.
l: don't think we need this test? a lot of mocking to test a deleted code path, I'd just get rid of this
The test mocks most of module setup just to cover a deleted code path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dev mode the Nuxt module aliased
@opentelemetry/resourcesto@opentelemetry/resources/build/src/index.js. Nuxt writes every alias into thepathsof the generated.nuxt/tsconfig.*.jsonfiles. Those configs have nobaseUrl, so withtypescript: { typeCheck: true }vue-tsc fails with TS5090 ("Non-relative paths are not allowed when 'baseUrl' is not set").The alias was a workaround for incomplete ESM imports in
@opentelemetry/resources(#15204). In v11 nothing in the Nuxt SDK's dependency tree uses that package anymore, so the alias can be removed instead of rewritten.Fixes #25188