Repository navigation
fix(core): Strip internal custom span name from streamed spans - #25212
Merged
Merged
Conversation
msonnb
added this pull request to stack #24891
October 9, 2026 09:02
Lms24
reviewed
Oct 9, 2026
| export function streamedSpanJsonToSerializedSpan(spanJson: StreamedSpanJSON): SerializedStreamedSpan { | ||
| const attributes = serializeAttributes(spanJson.attributes); | ||
| // oxlint-disable-next-line typescript/no-dynamic-delete | ||
| delete attributes[SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME]; |
Member
There was a problem hiding this comment.
wdyt about deleting the attribute in captureSpan right after converting it to JSON?
Doing it here means users would still see it in beforeSendSpan, which I think we should avoid.
Member
Author
There was a problem hiding this comment.
good point, moved it to captureSpan
Contributor
size-limit report 📦
|
msonnb
force-pushed
the
ms/strip-streamed-custom-span-name
branch
from
October 9, 2026 09:26
433aade to
f4e7e94
Compare
msonnb
force-pushed
the
ms/strip-streamed-custom-span-name
branch
from
October 9, 2026 09:42
f4e7e94 to
651f873
Compare
msonnb
marked this pull request as ready for review
October 9, 2026 09:56
msonnb
requested review from
Lms24 and
logaretm
and removed request for
a team
October 9, 2026 09:56
Lms24
approved these changes
Oct 9, 2026
msonnb
force-pushed
the
ms/strip-streamed-custom-span-name
branch
from
October 9, 2026 10:05
e827f88 to
57789a7
Compare
Base automatically changed from
ms/browser-tests-requests-web-vitals
to
develop
October 9, 2026 11:02
Co-Authored-By: OpenAI ChatGPT <codex@openai.com>
msonnb
force-pushed
the
ms/strip-streamed-custom-span-name
branch
from
October 9, 2026 11:02
57789a7 to
9f984f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry.updateSpanNamestoressentry.custom_span_namefor internal naming precedence, but streamed spans currently send it to the backend. Remove it during serialization, matching static spans while preserving the renamed span name.