Repository navigation
fix(profiling-node): Stop the trace lifecycle profiler when spans are unsampled - #25210
Merged
s1gr1d merged 2 commits intoOct 9, 2026
Conversation
s1gr1d
requested review from
andreiborza and
mydea
and removed request for
a team
October 9, 2026 08:53
3 tasks done
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c0cf2d0. Configure here.
A startProfiler() call after the chunk timer stopped a chunk, but before the scheduled next chunk started, began a new chunk. The scheduled restart then stopped it almost at once and sent a very short chunk. Start and stop now share one check that treats this gap as a running session. Also move the comment that explains the deferred restart to the setImmediate call.
s1gr1d
enabled auto-merge (squash)
October 9, 2026 09:15
s1gr1d
deleted the
sigridhuemer/js-3893-profiling-node-profilelifecycle-trace-never-stops-the
branch
October 9, 2026 09:26
47 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
profileLifecycle: 'trace', the profiler counted everyspanStartandspanEnd. Unsampled child spans emitspanStartbut neverspanEnd, so the count never got back to 0. The profiler kept running, and Node never exited.A fake-timer test stops profiling in the gap between two chunks and checks that no new chunk starts.
Fixes #25174