Repository navigation
Conversation
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit dfacd96. Configure here.
Contributor
size-limit report 📦
|
Express layer spans ended only on the response's finish event. When the client aborts, finish never fires, so the handler span never ended. Static transactions were sent without it and its subtree, and with span streaming its children were orphaned. Also end the layer span on close, which is when the http.server span ends, and mark it as cancelled. Fixes #25183 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bun 1.3.14, the version CI runs, emits no close event on the response when the client aborts, so the http.server span never ends there. Bun 1.4.0 emits it and the test passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chargome
force-pushed
the
express-span-client-abort
branch
from
October 9, 2026 09:57
114ec82 to
8d40ec4
Compare
chargome
marked this pull request as ready for review
October 9, 2026 10:18
chargome
requested review from
andreiborza,
isaacs and
mydea
and removed request for
a team
October 9, 2026 10:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Express layer spans only ended on the response's
finishevent. When the client aborts,finishnever fires, so the request handler span never ended. Static transactions were sent without it and everything under it, and with span streaming its children were orphaned.Layer spans now also end on
close, which is when thehttp.serverspan ends, and are marked ascancelled. Work that is still running when the client aborts ends after the transaction has been sent, so it is not part of the static transaction.Fixes #25183