Repository navigation
ci: Install Playwright in the background during E2E app builds - #25207
Merged
Merged
Conversation
Each E2E job spent about 25s installing Playwright after the app build, even though the install only needs the Playwright version. Most apps use the same version as the root workspace, so start that install in the background right after restoring caches. After the build, the app's own version is installed only if it differs from the root one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chargome
marked this pull request as ready for review
October 9, 2026 08:49
Member
Author
|
triggering a full ci run to verify |
JPeer264
approved these changes
Oct 9, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
LGTM. We should also link the public GH issue in the PR desc though
nicohrubec
previously requested changes
Oct 9, 2026
nicohrubec
left a comment
nicohrubec
left a comment
Member
There was a problem hiding this comment.
multiple tests in the full ci run fail in the Restore tarball artifacts step, so probably related?
Starting the background install right next to `download-artifact` made 13 of about 270 E2E jobs fail in a full run with "Unexpected end of JSON input" while the action read the event file. Start it after the downloads instead, where the next steps are plain shell commands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
@nicohrubec fixed |
47 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2E jobs installed Playwright after the app build. This uses the new parallel steps to install the root workspace's Playwright version in the background while the app builds. Apps on a different version still get theirs installed after the build. This saves about 16-19s per E2E job.
The background install starts after the artifact downloads on purpose. Starting it next to
download-artifactmade about 5% of jobs fail with "Unexpected end of JSON input".Refs #25134