Skip to content

test(node): Port HTTP request suites to span streaming #25191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicohrubec merged 4 commits into from
Oct 9, 2026
Merged

test(node): Port HTTP request suites to span streaming #25191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce0371c
test(node): Port HTTP request suites to span streaming
nicohrubec Oct 8, 2026
5a66be8
test(node): Restore comments explaining empty span expectations
nicohrubec Oct 8, 2026
dc512ac
Update dev-packages/node-integration-tests/suites/tracing/requests/ht…
nicohrubec Oct 9, 2026
fe7623c
Merge branch 'develop' into feat/http-request-tests-span-streaming
nicohrubec Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dev-packages/node-integration-tests/suites/tracing/requests/http-breadcrumbs/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracePropagationTargets: [/\/v0/, 'v1'],
Expand Down
1 change: 0 additions & 1 deletion ...ages/node-integration-tests/suites/tracing/requests/http-maxed-out-sockets/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
Expand Down
4 changes: 2 additions & 2 deletions dev-packages/node-integration-tests/suites/tracing/requests/http-maxed-out-sockets/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ describe('outgoing http with maxed-out agent sockets', () => {
await createRunner()
.withEnv({ SERVER_URL })
.expect({
transaction: {
// we're not too concerned with the actual transaction here since this is tested elsewhere
span: {
// Span contents are tested elsewhere.
},
})
.start()
Expand Down
1 change: 0 additions & 1 deletion ...s/node-integration-tests/suites/tracing/requests/http-no-trace-propagation/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
integrations: [Sentry.httpIntegration({ tracePropagation: false, spans: false })],
Expand Down
1 change: 0 additions & 1 deletion ...es/node-integration-tests/suites/tracing/requests/http-no-tracing-no-spans/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracePropagationTargets: [/\/v0/, 'v1'],
Expand Down
1 change: 0 additions & 1 deletion dev-packages/node-integration-tests/suites/tracing/requests/http-no-tracing/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracePropagationTargets: [/\/v0/, 'v1'],
Expand Down
1 change: 0 additions & 1 deletion ...node-integration-tests/suites/tracing/requests/http-sampled-no-active-span/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
Expand Down
1 change: 0 additions & 1 deletion dev-packages/node-integration-tests/suites/tracing/requests/http-sampled/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
Expand Down
4 changes: 2 additions & 2 deletions dev-packages/node-integration-tests/suites/tracing/requests/http-sampled/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ describe('outgoing http', () => {
await createRunner()
.withEnv({ SERVER_URL })
.expect({
transaction: {
// we're not too concerned with the actual transaction here since this is tested elsewhere
span: {
// Span contents are tested elsewhere, we just want to know that a span envelope was sent
},
})
.start()
Expand Down
1 change: 0 additions & 1 deletion dev-packages/node-integration-tests/suites/tracing/requests/http-unsampled/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracePropagationTargets: [/\/v0/, 'v1'],
Expand Down
1 change: 0 additions & 1 deletion dev-packages/node-integration-tests/suites/tracing/requests/traceparent/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1,
Expand Down
14 changes: 8 additions & 6 deletions dev-packages/node-integration-tests/suites/tracing/requests/traceparent/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { SENTRY_OP } from '@sentry/conventions/attributes';
import { HTTP_CLIENT } from '@sentry/conventions/op';
import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { RUNTIME } from '../../../../utils';
Expand All @@ -23,14 +25,14 @@ describe('outgoing traceparent', () => {
await createRunner()
.withEnv({ SERVER_URL })
.expect({
// The propagated `sentry-trace` must reference the `http.client` span, not the surrounding transaction span.
transaction: event => {
// The propagated `sentry-trace` must reference the `http.client` span, not the surrounding segment span.
span: container => {
const propagatedSpanId = outgoingSentryTrace?.split('-')[1];
const httpClientSpan = event.spans?.find(span => span.op === 'http.client');
const httpClientSpan = container.items.find(span => span.attributes[SENTRY_OP]?.value === HTTP_CLIENT);

expect(httpClientSpan).toBeDefined();
expect(propagatedSpanId).toBe(httpClientSpan?.span_id);
expect(propagatedSpanId).not.toBe(event.contexts?.trace?.span_id);
expect(propagatedSpanId).not.toBe(container.items.find(span => span.is_segment)?.span_id);
},
})
.start()
Expand All @@ -57,8 +59,8 @@ describe('outgoing traceparent', () => {
await createRunner()
.withEnv({ SERVER_URL })
.expect({
transaction: {
// we're not too concerned with the actual transaction here since this is tested elsewhere
span: {
// Span contents are tested elsewhere.
},
})
.start()
Expand Down
Loading