Repository navigation
test(node): Port fetch request suites to span streaming - #25189
Merged
Merged
Conversation
Co-Authored-By: GPT-6 <codex@openai.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bec19f5. Configure here.
Co-Authored-By: GPT-6 <codex@openai.com>
nicohrubec
commented
Oct 8, 2026
| expect(headers['sentry-trace']).toEqual(expect.stringMatching(/^([a-f\d]{32})-([a-f\d]{16})-0$/)); | ||
| expect(headers['sentry-trace']).not.toEqual('00000000000000000000000000000000-0000000000000000-0'); | ||
| expect(headers['sentry-trace']).toEqual(expect.stringMatching(/^([a-f\d]{32})-([a-f\d]{16})-1$/)); | ||
| expect(headers['sentry-trace']).not.toEqual('00000000000000000000000000000000-0000000000000000-1'); |
Member
Author
There was a problem hiding this comment.
this changes because for span streaming parentless fetch spans get sampled
nicohrubec
marked this pull request as ready for review
October 8, 2026 16:15
nicohrubec
requested review from
Lms24,
andreiborza and
isaacs
and removed request for
a team
October 8, 2026 16:16
Lms24
approved these changes
Oct 9, 2026
Co-Authored-By: GPT-6 <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the fetch request suites with the default span-streaming lifecycle.
Part of #24135