Repository navigation
Conversation
chargome
added this pull request to stack #25166
October 8, 2026 09:12
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
chargome
force-pushed
the
feat/neon-integration
branch
from
October 8, 2026 09:37
9b1cb9f to
01f61fd
Compare
chargome
force-pushed
the
test/neon-e2e
branch
from
October 8, 2026 09:37
39e9d8b to
9fa932b
Compare
chargome
force-pushed
the
feat/neon-integration
branch
from
October 8, 2026 09:40
01f61fd to
66187ed
Compare
chargome
force-pushed
the
test/neon-e2e
branch
from
October 8, 2026 09:40
9fa932b to
9524e95
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9524e95. Configure here.
| // query it issues has no parent span and is skipped. | ||
| ...(RUNTIME === 'deno' | ||
| ? [] | ||
| : [expectedDbSpan({ name: 'SELECT "User"', statement: 'SELECT "name" FROM "User"' })]), |
There was a problem hiding this comment.
Conditional assertion in one test
Low Severity
The websocket driver test branches on RUNTIME inside one assertion. This is flagged because the review rules call out conditionals in a single test; Node and Deno expect different pool-query spans.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 9524e95. Configure here.
Run both Neon drivers against Neon's own proxy in front of a local Postgres, so the HTTP and WebSocket wire protocols are the real ones. Covers queries, tagged templates, batches, failing statements and pool queries in ESM and CJS under the default span lifecycle. ws is needed for the WebSocket driver on Node 20, which has no global WebSocket. Refs #25144 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
chargome
force-pushed
the
test/neon-e2e
branch
from
October 8, 2026 10:45
9524e95 to
59ccb70
Compare
Member
Author
|
Folded into #25164 so the integration PR carries its own end-to-end coverage, as the review rules ask. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs both Neon drivers end to end against Neon's own proxy (
ghcr.io/timowilhelm/local-neon-http-proxy) in front of a local Postgres, so the HTTP/sqland WebSocket/v2wire protocols are the real ones rather than mocks. Coverssql.query(), tagged templates,transaction()batches, a failing statement and pool queries, in ESM and CJS under the default span lifecycle.wsis added because Node 20 has no globalWebSocket.The suite is excluded on Bun like the other database suites, since
bun runcannot inject the diagnostics channels. On Deno the pool's connect callback runs outside the segment's async context, so that one query has no parent span and is not expected there.Stacked on #25164.
Refs #25144