Repository navigation
fix(core): Record span outcomes for spans dropped when building a transaction - #25048
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
…nsaction Unfinished child spans are now reported as `invalid` and spans cut off by the 1000 span cap as `buffer_overflow`. Unfinished children are not counted when the deferred capture strategy tracks captured spans, since those are sent later as orphan transactions. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
lms/fix-core-convert-span-outcomes
branch
from
October 9, 2026 11:13
5131f37 to
15d496c
Compare
Lms24
marked this pull request as ready for review
October 9, 2026 11:13
andreiborza
approved these changes
Oct 9, 2026
47 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the static trace lifecycle, building a transaction silently dropped two kinds of child spans without a client outcome: children that hadn't finished yet, and spans beyond the 1000 span cap. These are now recorded as
invalid(span lacks an end timestamp, so it fails validation) andbuffer_overflow(the transaction's fixed-size span buffer overflowed), so dropped span counts show up in client reports.